search

cividesk / com.cividesk.email.sparkpost

This extension allows CiviCRM to send emails and process bounces through the SparkPost service.
10 stars 30 forks source link

Dont't work in Europe #69

Open olivierh65 opened 5 years ago

olivierh65 commented 5 years ago

Hi, Sparkpost use a eu.sparkpost.com for European users. Replacing all URLs https://*sparkpost.com by https://*.eu.sparkpost.com allow the plugin to works fine.

It will be nice to add an option to define the URL (sparkpost.com or eu.sparkpost.com

Regards.

nganivet commented 5 years ago

@olivierh65 Can you fund this improvement? We can do that for 300 Euros. Thanks.

olivierh65 commented 5 years ago

I use CiviCRM in a very small association, with a small budget. But I have some time, so I made the changes and created a pull request (#70).

I've also added an option to allow sparkpost tracking. This is usefull to follow transactionnal mails.

Regards.

Le 27/12/2018 à 19:10, nganivet a écrit :

@olivierh65 https://github.com/olivierh65 Can you fund this improvement? We can do that for 300 Euros. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cividesk/com.cividesk.email.sparkpost/issues/69#issuecomment-450202906, or mute the thread https://github.com/notifications/unsubscribe-auth/ANHen1uuikeOUhCtaDXm7YlcNeIdWQ0Rks5u9Q0jgaJpZM4Zf6LJ.

herbdool commented 4 years ago

@nganivet I've cleaned up the PR here https://github.com/cividesk/com.cividesk.email.sparkpost/pull/86. I've improved the code syntax, labels and removed the tracking setting since that's better off in a new issue.

Please review and let me know if it needs tweaking or if it can be merged. Thanks for your help on this.

herbdool commented 4 years ago

@nganivet thanks for merging. Would you be able to create a new release? It's been a couple years and 16 commits since the last release.

herbdool commented 4 years ago

I believe this issue can closed.