cividesk / com.cividesk.email.sparkpost

This extension allows CiviCRM to send emails and process bounces through the SparkPost service.
10 stars 30 forks source link

Array to String Conversion errors #85

Open ryanlrobinson opened 5 years ago

ryanlrobinson commented 5 years ago

Recently began testing out Sparkpost and this extension. It's mostly great, but have one issue to look at. On the settings page (/civicrm/admin/setting/sparkpost) this PHP error appears dozens of times:

Notice: Array to string conversion in Civi\Core\SettingsMetadata::_filterSettingsSpecification() (line 149 of /home/cividemo/public_html/sites/all/modules/civicrm/Civi/Core/SettingsMetadata.php).

Anything I've tried still works despite the error, but best case it is disconcerting.

PHP 7.2.20 CiviCRM 5.15.1 Sparkpost extension 1.3, initially tried with the version in the extension directory, then tried with the latest version here

herbdool commented 4 years ago

I get the same error. I think it's related to the webhook throwing errors on the settings page. But I'm not sure if that's happening for everyone. When we upgraded to PHP 7.2 the callback URL got lost. Not sure it's related but I suspect that something in the extension has a bug in how settings metadata is set up.

nganivet commented 4 years ago

Guys - I will let you debug this one as I do not have any customer instance on PHP 7.2 and/or CiviCRM 5.15. Please submit a PR, making sure you keep backwards compatibility with previous versions of CiviCRM and PHP. Thanks.

herbdool commented 4 years ago

I think it's related to https://github.com/cividesk/com.cividesk.email.sparkpost/issues/66