search

civiform / civiform

CiviForm simplifies the application process for government benefits programs by re-using applicant data for multiple benefits applications. It's being developed by Google.org and Exygy, in collaboration with the City of Seattle and community contributors.
https://civiform.us
Apache License 2.0
90 stars 56 forks source link

Programs can be applied for despite disabled status #8140

Closed jhvhs-bloom closed 2 weeks ago

jhvhs-bloom commented 1 month ago

If an applicant applies for a program and leaves the in progress application open in their browser, they can still submit their application despite the program being disabled.

This bug affected our Production instance (v2.4.2). A program we disabled on July 15, 2024 had three applications come through days after July 15, 2024. Two of the applicants are registered users and one is a guest user.

We replicated the issue in our Test instance (v2.4.2):

  1. Person 1 begins applying for a program and leaves the tab open in their browser
  2. Person 2 (as admin) publishes the program with the Disabled visibility state
  3. Person 1 submits application

Please let me know if you need me to clarify anything.

sethCOB commented 1 month ago

This PR may be discussing a similar thing, not sure: #5043

dkatzz commented 1 month ago

Once an application is started, it will continue to be on the program version that it was on when the application was started. However, there's a feature flag that was just released in 2.4.3 (FASTFORWARD_ENABLED) that will fast forward an in progress application to the latest program version. Let me know if that fixes the issue you're seeing.

jhvhs-bloom commented 1 month ago

I upgraded our test instance to 2.4.3 and enabled the FASTFORWARD_ENABLED flag. The applicant gets an error message when they try to navigate different screens.

Overall this is good--but is it possible to change the error message?

Instead of directing folks to contact technical support, the message could let the applicant know that this program is disabled or no longer available.

civiform-disabled-program-error

dkatzz commented 1 month ago

Yes - it seems like there may be a bug with fast forward in this case. I've filed a bug for this particular issue - https://github.com/civiform/civiform/issues/8290. Feel free to add any additional details and thank you for noticing this!

dkatzz commented 2 weeks ago

This should be fixed in the latest version of CiviForm https://github.com/civiform/civiform/releases/tag/v2.8.0