civio / verba

Explora los Telediarios de RTVE desde 2014
https://verba.civio.es
GNU Affero General Public License v3.0
33 stars 5 forks source link

chore: update deps to fix build issue (prettier) #109

Closed palmerabollo closed 3 years ago

palmerabollo commented 3 years ago

Añade "prettier" a las devDependencies de la web. Es una peer dependency de @vue/eslint-config-prettier y sin ella da este error al hacer npm run start, siguiendo los pasos del README:

npm run start

> verba-volant@1.0.0 start /Users/guido/verba
> run-p start:api start:web

> verba-volant@1.0.0 start:api /Users/guido/verba
> npm run start --prefix api

> verba-volant@1.0.0 start:web /Users/guido//verba
> npm run start --prefix web

> verba-volant-api@1.0.0 start /Users/guido/verba/api
> nodemon --exec babel-node src/index.js

> verba-volant-web@1.0.0 start /Users/guido/verba/web
> vue-cli-service serve

[nodemon] 2.0.6
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): *.*
[nodemon] watching extensions: js,mjs,json
[nodemon] starting `babel-node src/index.js`
 INFO  Starting development server...
Server running on port 8888
98% after emitting CopyPlugin

 ERROR  Failed to compile with 1 error                                                                                                                                                                       12:25:38 PM

 error  in ./src/main.js

Syntax Error: Error: Cannot find module 'prettier'
Require stack:
- /Users/guido/verba/web/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js
- /Users/guido/verba/web/node_modules/eslint/lib/cli-engine/config-array-factory.js
- /Users/guido/verba/web/node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js
[...]

Además elimino la dependencia run-p del package.json principal. Es un alias que instala npm-run-all, no es necesario indicar esa dependencia.

dcabo commented 3 years ago

Gracias 👍