BUG A file-like object as arg to df.to_csv must have the method getvalue

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

BUG A file-like object as arg to df.to_csv must have the method getvalue #259

Closed jacksonllee closed 6 years ago

jacksonllee commented 6 years ago

Since pandas v0.23.1 (specifically from https://github.com/pandas-dev/pandas/pull/21300), if a file-like object is passed into df.to_csv, the object must have the method getvalue, or else an AttributeError is raised (which is what we have observed from #258). An io.TextIOWrapper object doesn't have the method getvalue, which caused the latest build failures in #258. This PR switches to io.StringIO instead.

jacksonllee commented 6 years ago

AppVeyor has been turned on, but obviously there's no AppVeyor configuration yet (upcoming from #258) and hence the relevant build "failure", which should be ignored for this PR.