MAINT add python 3.7 compatibility

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

MAINT add python 3.7 compatibility #278

Closed elsander closed 5 years ago

elsander commented 5 years ago

This PR adds tests for Python 3.7 compatibility. #266 mentions updating the documentation, but I couldn't find anywhere in the docs that explicitly mention compatible Python versions. Happy to add a section if that would be helpful.

Fixes #266.

stephen-hoover commented 5 years ago

I see some metadata in the setup.py file that will need to be updated and a list of supported Python versions in the README.rst.

stephen-hoover commented 5 years ago

The AppVeyor update made me realize that the AppVeyor tests aren't running any more. If it's a simple fix, I'd like to turn that back on and run the Windows Python 3.7 tests before merging this.

elsander commented 5 years ago

I emailed IT to see if they can trigger a build. I know github was changing CI connections a few months back, so I wonder if this was a casualty of those changes.

elsander commented 5 years ago

Looks like the appveyor tests are running, they're just not showing up in the PR as checks. https://ci.appveyor.com/account/civisanalytics/projects

elsander commented 5 years ago

I talked with IT and it's not clear why the appveyor build isn't showing up in the PR. I'm not sure there's anything else I can do on my end, but I can confirm that the tests are passing on all versions of Windows, including 3.7. I think that resolving the github app connection is out of scope for this ticket, but I can make a separate one so that we don't forget about it.