FIX get_table_id should correctly handle quoted schema.tablename

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

FIX get_table_id should correctly handle quoted schema.tablename #283

Closed jacksonllee closed 5 years ago

jacksonllee commented 5 years ago

Resolves #276

jacksonllee commented 5 years ago

It looks like none of the methods under the MetaMixin class have tests. To document the desired behavior fixed by this current PR, I've put down examples in the docstring of get_table_id (following a similar pattern from other methods in the class, such as get_database_credential_id).
The Travis CI builds didn't kick off -- I'm emailing IT-Support. Marking this PR as work in progress for now.

jacksonllee commented 5 years ago

According to IT-support (who emailed Travis CI's support), Travis CI doesn't yet support builds for PRs marked as "draft" (a new feature on GitHub). Closing this PR in favor of #285.