civisanalytics / civis-python

Civis API Python Client
BSD 3-Clause "New" or "Revised" License
34 stars 26 forks source link

DEP Deprecate headers parameter of dataframe_to_civis #307

Closed stephen-hoover closed 5 years ago

stephen-hoover commented 5 years ago

By default, to_csv will always write a header. It doesn't make sense to let users separately set the headers parameter on the import; we'll always know what it is. This also fixes a problem with automatic header detection in Civis Platform not always recognizing a header row properly.

I was able to reproduce @elsander 's error from #263 with the original dataset. The change in this PR fixes it, by being explicit about the presence of a header row.

Closes #263 .