COMPAT Deprecation decorator takes multiple parameter names

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

COMPAT Deprecation decorator takes multiple parameter names #311

Closed stephen-hoover closed 5 years ago

stephen-hoover commented 5 years ago

In Python v3, multiple layers of the deprecation decorator work as expected. But we run into problems with Python v2.7 (apparently due to missing features in the Signature class). If the decorator takes multiple parameter names, it's more complex, but will be compatible with more Python versions.

stephen-hoover commented 5 years ago

@keithing , I ran into this problem when doing #307 . I could also do the deprecation there without using this decorator, in which case I don't need this PR. Let me know if you prefer that.

stephen-hoover commented 5 years ago

Yes, that's right.