search

civisanalytics / civis-python

Civis API Python Client
BSD 3-Clause "New" or "Revised" License
34 stars 26 forks source link

[PARO-720] ENH Model sharing helpers #315

Closed stephen-hoover closed 5 years ago

stephen-hoover commented 5 years ago

A CivisML model has File and Project run outputs, each of which need to be shared to effectively share the "model". This helper will transparently handle sharing the run outputs. Include JSONValue in case a future version of CivisML uses that. The functions are patterned after the autogenerated API sharing endpoints.

stephen-hoover commented 5 years ago

@elsander , see what you think of the naming and other design choices here. It's not obvious what the right interface would be. I considered adding a list_models_shares function as well, but doing that right would be really complex, and I wasn't sure it was worth it.

elsander commented 5 years ago

I think the function names make a lot of sense. I could see the list function being useful, but if it's complex to implement it's probably not worth doing right now. If we hear requests for it we could reevaluate.

stephen-hoover commented 5 years ago

@elsander , I addressed your comments.