[CIVP-15320] Add max_file_size param to civis_to_multifile_csv

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

[CIVP-15320] Add max_file_size param to civis_to_multifile_csv #342

Closed uttercm closed 4 years ago

uttercm commented 4 years ago

JIRA Ticket: CIVP-15320

Summary: Adding the max_file_size parameter to the civis.io.civis_to_multifile_csv

Testing:

[x] Updated specs
[x] Performed manual tests

Notes: used the civis.io.civis_to_multifile_csv function to create files with different max file sizes and verified the file size sql scripts are: 55697443 and 55697108

Additional Info:

uttercm commented 4 years ago

@elsander is it okay that the build is failing due to the 3.4 error, I see that there is a PR to deprecate that so do I need to worry about that

elsander commented 4 years ago

We're supporting 3.4 until April, so it does need to pass on 3.4 for this upcoming release.

uttercm commented 4 years ago

see Jackson's comment in his PR: https://github.com/civisanalytics/civis-python/pull/341#issuecomment-571342110, seems like the failure on 3.4 needs has to do with PyYAML's requirements, if we want it to pass we will have to fix the dependancies

jkulzick commented 4 years ago

@elsander see my comment above. I guess @uttercm can pin to a lower version