search

civisanalytics / civis-python

Civis API Python Client
BSD 3-Clause "New" or "Revised" License
34 stars 26 forks source link

[APIC-300] bump minimum pubnub version #397

Closed patr1ckm closed 4 years ago

patr1ckm commented 4 years ago

From the pubnub changelog, they fixed all the keyword clashes (for async and await) since the v4.1.2 released in Sept 2018.

I don't fully understand all the reasons I ran into this issue (why an older pubnub version was pulled in on my fresh install), but it's quick change.

mheilman commented 4 years ago

Would you mind also updating the line in the requirements.txt?

jacksonllee commented 4 years ago

One more spot to change:

https://github.com/civisanalytics/civis-python/blob/3fdceb90ec8ffc1bf60f0a5014b5d5cb8209f3c7/requirements.txt#L7

mheilman commented 4 years ago

@jacksonllee, do you think we should only allow squash and merge? It's possible to disable the other 2 options

jacksonllee commented 4 years ago

do you think we should only allow squash and merge?

Yeah, allowing "squash and merge" only for this repo seems reasonable. If we did come across edge cases where we'd need the other merge options, we could always re-enable them...