civisanalytics / civis-python

Civis API Python Client
BSD 3-Clause "New" or "Revised" License
34 stars 26 forks source link

[APIC-305] Require sql_type for every column when table_columns is provided #400

Closed izzy-zelichenko closed 4 years ago

izzy-zelichenko commented 4 years ago

APIC-305

Ensure data types are detected when the destination table does not exist or it is being dropped and table_columns are provided but do not contain a sql_type for every column.

izzy-zelichenko commented 4 years ago

We now have a test for every case when table_columns are provided

izzy-zelichenko commented 4 years ago

I removed the test I previously added because I realized it was nearly identical to the test test_civis_file_to_table_table_doesnt_exist_provide_table_columns, so I just updated that existing test to have two table_columns provided to be more thorough.

mheilman commented 4 years ago

@izzy-zelichenko, would you mind making a followup PR to add an item to the changelog for this?

izzy-zelichenko commented 4 years ago

@mheilman Sure thing.