search

civisanalytics / civis-python

Civis API Python Client
BSD 3-Clause "New" or "Revised" License
34 stars 26 forks source link

[APIC-284] remove python 3.5 support since it is reaching EOL #404

Closed mheilman closed 4 years ago

mheilman commented 4 years ago

'Python 3.5 will reach its "end of life" at the end of September 2020.' (https://www.python.org/downloads/release/python-3510/)

jacksonllee commented 4 years ago

Everything looks good. Should we also throw in the python_requires=">=3.6" kwarg in the setup call in setup.py? Reference

mheilman commented 4 years ago

Yeah, that seems like a good idea. At first, I was concerned about it breaking somebody's job, but if they're using pypi, then pypi will give them the previous version because the classifiers will say the next version doesn't support python 3.5.