civisanalytics / civis-python

Civis API Python Client
BSD 3-Clause "New" or "Revised" License
34 stars 26 forks source link

[APIC-306] Fixed a bug in parsing responses that included "update" as a key #410

Closed mheilman closed 4 years ago

mheilman commented 4 years ago

This fixes a bug where a column named "update" would cause response parsing to fail for /tables endpoints.

The civis.response.Response provides convenient access to response attributes (e.g., response.attrib as opposed to response['attrib']). In retrospect, perhaps it'd have been better not to have that functionality recur all the way down the response structure (or at least not into user-provided table info), but that ship has sailed, and in order to minimize breaking changes, this PR should preserve the existing functionality and avoid the bug.