[CIVP-19775] ENH add job and run ID to CivisJobFailure from CivisFuture

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

[CIVP-19775] ENH add job and run ID to CivisJobFailure from CivisFuture #426

Closed jacksonlee-civis closed 2 years ago

jacksonlee-civis commented 2 years ago

This PR adds the job ID and run ID to the exception message of CivisJobFailure coming from a CivisFuture object.

jacksonlee-civis commented 2 years ago

The most recent two commits were structured to facilitate code review:

55c388e simply moved the changes from #416, from ContainerFuture to CivisFuture, with no other changes (not even the tests). The CI builds failed expectedly.
3150a53 made the necessary changes to make the tests pass.

Still not ready for a full review yet -- I'm tidying up a couple loose ends.

jacksonlee-civis commented 2 years ago

Just switched this PR back to the "draft" status for now as I'll need to check a couple more things. Will tag for review when it's ready again

jacksonlee-civis commented 2 years ago

@ggarcia-civis This PR is ready for review again. I've tested this PR branch for triggering a CivisJobFailure from a future object coming from different Platform scripts: Python, SQL, Container, and Custom scripts -- the logs look as expected and desired. The test job links are in the linked JIRA ticket (not posting them in a public repo here).