[CIVIS-1786] MAINT rename master to main

civisanalytics / civis-python

Civis API Python Client

BSD 3-Clause "New" or "Revised" License

34 stars 26 forks source link

[CIVIS-1786] MAINT rename master to main #460

Closed jclairelopez closed 1 year ago

jclairelopez commented 1 year ago

Updated references from 'master' to 'main'

[X] (For Civis employees only) Reference to a relevant ticket in the pull request title
[X] Changelog entry added to CHANGELOG.md at the repo's root level
[X] Description of change in the pull request description
[ ] If applicable, unit tests have been added and/or updated
[x] The CircleCI builds have all passed

jclairelopez commented 1 year ago

@jclairelopez Thank you for working on this! After the following two small updates are made, I think this is good to go:

There's a "master" branch reference in an URL in examples/PythonAPIClientDemo.ipynb that needs to be updated.

The changelog entry for this PR should be in the "Changed" section, see my comment below.

Hey, no problem. I moved the changelog entry, but I'm not seeing the master branch reference in the notebook you referenced. Can you screenshot it for me?

jacksonlee-civis commented 1 year ago

I'm not seeing the master branch reference in the notebook you referenced.

See the source code of the notebook and search for "master"? https://raw.githubusercontent.com/civisanalytics/civis-python/5de514c6262055933edd452f16a61605083a0db1/examples/PythonAPIClientDemo.ipynb

jclairelopez commented 1 year ago

I'm not seeing the master branch reference in the notebook you referenced.

See the source code of the notebook and search for "master"? https://raw.githubusercontent.com/civisanalytics/civis-python/5de514c6262055933edd452f16a61605083a0db1/examples/PythonAPIClientDemo.ipynb

Found it. Thanks!