search

civisanalytics / civis-r

Civis API Client for R: https://civisanalytics.com/products/civis-platform/
Other
16 stars 12 forks source link

use credential if provided #219

Closed emmacooperpeterson closed 4 years ago

emmacooperpeterson commented 4 years ago

I may be missing some important context here, but this enables passing a credential to query_civis(). Definitely open to discussing other options!

emmacooperpeterson commented 4 years ago

@patr1ckm thanks for the test/query_civis_file suggestion ! i'll get started on that

patr1ckm commented 4 years ago

@emmacooperpeterson is this ready? Thanks again!

emmacooperpeterson commented 4 years ago

@patr1ckm i haven't had any time to finish this up 😩i think the last remaining piece is adjusting the test for query_civis_file

emmacooperpeterson commented 4 years ago

@patr1ckm i think this is ready! the tests are passing but i'm not totally sure i updated them correctly

patr1ckm commented 4 years ago

LGTM!

Thanks for contributing, and the tests look 🥇