civisanalytics / python-glmnet

A python port of the glmnet package for fitting generalized linear models via penalized maximum likelihood.
Other
262 stars 59 forks source link

Remove try-catch numpy requirement #58

Closed zhzhang closed 5 years ago

zhzhang commented 5 years ago

The install_requires kwarg in setup() should already cover this case. These lines are breaking install via pip with a requirements file, as there's no way to guarantee numpy is already installed before this setup.py is called.

zhzhang commented 5 years ago

closing, sorry this was sloppy. let me do it properly and put up the pr again.