search

civisanalytics / swagger-diff

Utility for comparing two Swagger specifications.
BSD 3-Clause "New" or "Revised" License
264 stars 32 forks source link

Differences not being reported by swagger-diff #50

Closed gustavlasko closed 7 years ago

gustavlasko commented 7 years ago

Trying to diff the attached swagger files, I know there are changes, but swagger-diff is reporting none. Running:

gem install swagger-diff swagger-diff staging-swagger.json dev-swagger.json

Running on windows 8. dev-swagger.json.txt staging-swagger.json.txt

jeffreyc commented 7 years ago

Thanks for the report, and for the examples! It looks like Swagger::Diff doesn't handle the situation where an object has properties (i.e., nested inline objects vs. references). This looks like a 2-line fix (plus tests), so hopefully I can release a bugfix to address this soon.

jeffreyc commented 7 years ago

I just released Swagger::Diff 1.1.1, a bugfix release addressing this issue. If you encounter any other problems, please let us know.

gustavlasko commented 7 years ago

Thanks for the fast response, I will test it out and let you know if I run into any issues.

On Wed, Aug 23, 2017, 16:09 jeffreyc notifications@github.com wrote:

I just released Swagger::Diff 1.1.1, a bugfix release addressing this issue. If you encounter any other problems, please let us know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/civisanalytics/swagger-diff/issues/50#issuecomment-324384749, or mute the thread https://github.com/notifications/unsubscribe-auth/AWJXIuxrVSs7eNUixqWZ9T3_8Xx286Mjks5sbE67gaJpZM4O_ExF .