Open Brennok opened 3 months ago
Looks like it might be an issue with Node 20 and socket connections. Nothing really changed there so not sure why it would just now show up. I think theres a fix in Node for it so let me see if maybe we need to upgrade that.
@Brennok I updated things in 1.18.0 to specify the version of Node it uses. I think this should resolve the issue you are seeing. Test it out and let me know. Thanks!
@cmoody I am still seeing the errors. Not noticing anything other than the initial delay during startup when it is scanning all files. I haven't run the desktop link since about two weeks ago so it had to do a pretty big refresh.
It was showing disconnected with yellow so I tried to update the link key in case, but I had to wait for the scan to complete for it to save.
It does look like others had the same issue depending on node used, https://github.com/nodejs/node/issues/51354, guessing you probably saw this already, but in case and no idea if related. Same error though.
@Brennok are you on WIndows NT? Im going down some rabbit holes on this. I found this issue https://github.com/nodejs/node/issues/50655 which I think might relate. Looking at Electron versions and their node compatibility. https://www.electronjs.org/docs/latest/tutorial/electron-timelines I set us to Node v20.12.2 but we are running Electron v29.1.6. Im thinking whats used to run dev is not how it gets compiled or theres still an error in the version of Node we are using.
Also found it might be fix in v20.13.1. Im going to try to upgrade Electron and Node and see if that helps.
I am on Win 11 pro. Only seeing the errors in the log so not sure what if any issues it might be having.
On Fri, May 17, 2024, 1:32 PM Chase Moody @.***> wrote:
@Brennok https://github.com/Brennok are you on WIndows NT? Im going down some rabbit holes on this. I found this issue nodejs/node#50655 https://github.com/nodejs/node/issues/50655 which I think might relate. Looking at Electron versions and their node compatibility. https://www.electronjs.org/docs/latest/tutorial/electron-timelines I set us to Node v20.12.2 but we are running Electron v29.1.6. Im thinking whats used to run dev is not how it gets compiled or theres still an error in the version of Node we are using.
Also found it might be fix in v20.13.1. Im going to try to upgrade Electron and Node and see if that helps.
— Reply to this email directly, view it on GitHub https://github.com/civitai/civitai-link-desktop/issues/44#issuecomment-2118087387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMOY6SFY2ZYBUA4DZFHRNOLZCY5MTAVCNFSM6AAAAABG7DS6LCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGA4DOMZYG4 . You are receiving this because you were mentioned.Message ID: @.***>
@Brennok 1.20.0 Should have Node 20.13.1 which I think fixes this. 🤞
@cmoody Unfortunately I am still seeing the error though not as often. It is still loading models though.
[2024-05-24 12:23:47.741] [info] Starting App... [2024-05-24 12:23:48.305] [info] Checking for update [2024-05-24 12:23:48.305] [info] App ready: { version: '1.20.0', platform: 'win32', platformVersion: '10.0.22631', arch: 'x64' } [2024-05-24 12:31:57.786] [info] Update for version 1.20.0 is not available (latest version: 1.20.0, downgrade is disallowed). [2024-05-24 12:32:38.244] [error] Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals. Please open an issue with this stack trace at https://github.com/nodejs/node/issues
at assert (node:internal/assert:14:11)
at internalConnectMultiple (node:net:1118:3)
at Timeout.internalConnectMultipleTimeout (node:net:1687:3)
at listOnTimeout (node:internal/timers:575:11)
at process.processTimers (node:internal/timers:514:7)
[2024-05-24 12:42:02.302] [error] Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals. Please open an issue with this stack trace at https://github.com/nodejs/node/issues
at assert (node:internal/assert:14:11)
at internalConnectMultiple (node:net:1118:3)
at afterConnectMultiple (node:net:1667:5)
With 1.16.0 and 1.16.1 I am seeing the below error. I had a few more with 1.16.0, but it looks like the old logs were overwritten already so might be worth expanding how many old logs are maintained for those of us with too many files.
1.16.0 eventually got to a working state, but continued to run pretty heavily in the background. 1.16.1 never completed and just hung as unresponsive for a good hour or more before I closed it via the task manager.
1.16.1 [2024-04-29 16:55:38.906] [error] Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals. Please open an issue with this stack trace at https://github.com/nodejs/node/issues
main 1.16.1.txt