search

civkit / civkit-node

CivKit Node
Other
65 stars 12 forks source link

31 v2 of logging #36

Closed dapsavoie closed 1 year ago

dapsavoie commented 1 year ago

Due to the issues with the pipeline and merge conflicts, i recreated the code for issue 6 here.

It contains a few edits and updates. Feel free to review and let me know what you think.

ariard commented 1 year ago

Note you might have to rebase.

dapsavoie commented 1 year ago

Note you might have to rebase.

I think it should be fine? Seems we got around the conflict merge issue.

dapsavoie commented 1 year ago

@ariard I think we can land? Thanks for patience on review with this :). Happy to make any changes if you see but will certainly add more in future branches.

ariard commented 1 year ago

Landed :)

dapsavoie commented 1 year ago

Its a pleasure :)