civkit / civkit-node

CivKit Node
Other
65 stars 12 forks source link

Feat/verify mainstay inclusion #78

Closed DhananjayPurohit closed 11 months ago

ariard commented 1 year ago

see #79 with functional RPC calls on bitcoind

with following config details

# Password for JSON-RPC connections
rpcpassword=hello_world

# Username for JSON-RPC connections
rpcuser=civkitd_client

# Use the chain <chain> (default: main). Allowed values: main, test,
# signet, regtest
chain=regtest

implementing verifytxoutproof passthrough, that way civkit sample should be able to verify proofs by relying on a civkitd node, alternatively.

will review more this one.

DhananjayPurohit commented 1 year ago

So, this verifytxoutproof should be called using the command from civkit-cli, right? Also the files having .proto extension need to be modified or its auto-generated?

ariard commented 1 year ago

So, this verifytxoutproof should be called using the command from civkit-cli, right?

This is bottom interface servicing all the civkit components that need themselves access to bitcoind state, so CredentialGateway and mainstay to verify inclusion proof for now (in the future maybe to serve some on-chain payment proof).

Also the files having .proto extension need to be modified or its auto-generated?

The .proto are manually edited and then auto-generated by the tonic framework in rust code which is itself compiled to binary.

Architecturally, I think it could be valuable to start using mainstay proof generation and verification in notaryd, for now just using as a front-end for mainstay server, then we can add more functionalities with time, e.g announcing mainstay as a service over ln gossips or nostr.

ariard commented 1 year ago

Will review more this one, we can add the good API for civkit clients matching the underlying mainstay operations in future PR.

ariard commented 11 months ago

Thanks for the work here - Rather to review when to manually fix the issues, see #109. You should be credited in the commit message. I’ll land it, we can do follow-up PRs after.