search

civo / civo-cloud-controller-manager

Kubernetes cloud-controller-manager for Civo
Apache License 2.0
4 stars 6 forks source link

Do not set status.ip when proxy protocol is set #5

Closed DMajrekar closed 2 years ago

DMajrekar commented 2 years ago

When the proxy protocol annotation (kubernetes.civo.com/loadbalancer-enable-proxy-protocol) is set, the IP of the LoadBalancer is not set, only the Hostname. This will mean that all traffic local to the cluster to the LoadBalancer end point is now sent via the LoadBalancer. This allows services like CertManager to work correctly.

This option is currently a workaround for the issue https://github.com/kubernetes/ingress-nginx/issues/3996, should be removed or refactored after the Kubernetes [KEP-1860]

This MR also adds some E2E tests and updates the project Readme.

vishalanarase commented 2 years ago

LGTM

alejandrojnm commented 2 years ago

LGTM