search

civo / civo-csi

A Container Storage Interface plugin/driver for Civo's managed k3s service
https://www.civo.com/kube100
2 stars 2 forks source link

Set driver version in the binary based on release version #25

Closed hlts2 closed 1 week ago

hlts2 commented 1 week ago

WHAT

The release version has been modified to be mappable to the binary. Additionally, a flag to output the version information has been added. This allows the version information to be checked without making an RPC call.

WHY

The version information of binary is incorrect. (The value returned by the RPC will be 0.0.1.)

FYI

This PR has been tested using the following methods.

  1. Docker build

    $ make VERSION=v1.10.4 docker

  2. Run docker contianer This version will be returned by RPC

$ docker run --rm {IMAGE_ID} --version
7:08AM INF CSI driver version=v1.10.4
hlts2 commented 1 week ago

@rytswd @DMajrekar @Praveen005 When you have a moment, could you please review this PR? :bow: