search

civo / civo-csi

A Container Storage Interface plugin/driver for Civo's managed k3s service
https://www.civo.com/kube100
2 stars 0 forks source link

Test case in volume counts has a bug #4

Closed kaihoffman closed 2 years ago

kaihoffman commented 2 years ago

The tests around volume quota capacity at https://github.com/civo/civo-csi/blob/master/pkg/driver/controller_server_test.go#L243 do not fail correctly - the volume counts test works as expected, but the volume size one does not seem to catch it correctly.

@RealHarshThakur is aware of the case from helping me with my MR on 26 Oct.

RealHarshThakur commented 2 years ago

@kaihoffman It actually works as expected. The way to test it was decrease the usage to invoke a failure of the test case(it was the other way around for the above cases).

kaihoffman commented 2 years ago

@RealHarshThakur Forgive me. I swear I remembered that you realised it was wrong but was going by a pen and paper to-do note.

I think I need a nap.

RealHarshThakur commented 2 years ago

No worries. :D Take rest!!