Open fernando-villalba opened 7 months ago
Can be a global one like --delete-dependent-resource that by default can be false and if you pass the api can delete all related object, we can use the same flag in terraform
@alejandrojnm There is already such flag in API which automatically deletes all the related resources? If yes then can you please specify which API.
@uzaxirr no we don't have and even the UI is not deleting them. We had some conversation around it multiple times, but they never translated into a practical action.
Hey @fernando-villalba @uzaxirr, I can solve this issue. Could you assign it to me?
I've submitted a pull request. Please review and let me know if any changes are required. @fernando-villalba @uzaxirr @alejandrojnm @alejandrojnm
Issue
Currently when you create and delete clusters, it leaves too many dependent resources and configuration behind, for example:
Deleting all of these by hand or scripting it separately is very tedious
We need flags that delete these resources together with the cluster.
Acceptance Criteria
1. I suggest making the deletion of firewalls and kubeconfig the default, and keep volumes by default but provide option to get rid of them
After all, you can always revert your firewalls and config is only valid for that cluster, so no point in keeping them for the vast majority of cases.
And then have flags to delete the volumes that may have important data.
So you could have flags like this:
civo kubernetes delete --delete-volumes
--> Deletes dependent volumescivo kubernetes delete --keep-firewalls
--> keeps dependent firewallscivo kubernetes delete --keep-kubeconfig
--> keeps dependent firewalls2. When deleting clusters let the user know what was left behind
Aside outputting what cluster names and ids were deleted, also output the volumes that were left behind, and as an info message sent to stderr, you can mention the flag to delete dependent volumes next time.