cjam / react-native-spotify-remote

React Native wrapper around the Spotify Remote SDK
MIT License
258 stars 101 forks source link

'SpotifyiOS.h' file not found - Example App #223

Open ghost opened 1 year ago

ghost commented 1 year ago

Hey @cjam, I'm getting some Xcode build errors while trying to get the example up and running.

Line 10 of RNSpotifyRemoteError: 'SpotifyiOS.h' file not found

I followed all of steps outline in the README.md and I also ran yarn submodules in the root directory. Here's a video of all the steps I took (I rotated the Spotify client secret shown in the video!)

Any idea of what I did wrong here?

toddriley commented 1 year ago

There are a couple issues with running the example app. The first is that line 14 of the Podfile assumes the dependency is in a parent directory instead of inside node_modules.

https://github.com/cjam/react-native-spotify-remote/blob/7c13126ec6ce5e990a83aa730b65382ce709e37a/example/ios/Podfile#L14

If you update this line to be the following:

pod 'RNSpotifyRemote', :path => '../node_modules/react-native-spotify-remote'

Then you'll get the same error because the react-native-spotify-remote dependency is missing from package.json. But if you run:

yarn add react-native-spotify-remote

Then that error will go away.

cjam commented 1 year ago

Hey, sorry for the delay. I'll have to take a gander at trying to run the example app again. As for @toddriley's comment, it is true that it points upward two directories. This was so that the example app would use the latest code within the library itself, so it was intended but perhaps it has stopped working as intended.

johra commented 1 year ago

Also getting the same problem, @cjam an update on example would be greatly appreciated. Trying to get the project running using Expo and EAS build. Almost done appart from this and also the linking of xcframework instead of framework.

chen-rn commented 1 year ago

Also getting the same problem, @cjam an update on example would be greatly appreciated. Trying to get the project running using Expo and EAS build. Almost done appart from this and also the linking of xcframework instead of framework.

Hey! did you manage to get this working with a Managed Expo dev client?

johra commented 1 year ago

Yes, but I hade to make a special expo-plugin for it, see here: https://github.com/EkornEvent/Tempofy/blob/master/spotify-plugin/index.js

chen-rn commented 1 year ago

Oh that looks fantastic!