search

cjb / GitTorrent

A decentralization of GitHub using BitTorrent and Bitcoin
MIT License
4.75k stars 262 forks source link

do not fail on unreadable directories #29

Closed anarcat closed 9 years ago

anarcat commented 9 years ago

this will still warn us, but at least not completely crash

this is stacked on top of #26

anarcat commented 9 years ago

so it seems this doesn't actually work, but i can't quite figure out why... it seems that glob.sync() still just doesn't return anything, even with strict: false. grml.

anarcat commented 9 years ago

nevermind that, it's the bare pattern that's screwed up... lots of fun, that glob library... :/

anarcat commented 9 years ago

alright, this glob pattern actually works, and the error suppression too.

sorry about the noise.

cjb commented 9 years ago

Cool. Is the added console.log intentional?

anarcat commented 9 years ago

it's not. a leftover of debugging :( want me to remove that? i am thinking it's pretty useful to have a one-liner list of repos, it certainly helped me to understand wtf was going on here :)

cjb commented 9 years ago

I don't think we need both the one-line list and a separate console.log for each one, so I'd remove one or the other, thanks.

anarcat commented 9 years ago

alright, done!

cjb commented 9 years ago

Merged, thanks Antoine!

@splinterofchaos, if you still have changes, maybe base them on current master now and ask to merge? Thanks!

anarcat commented 9 years ago

thanks, @cjb