search

cjb / codex-blackboard

Meteor app for coordinating solving for our MIT Mystery Hunt team
GNU Affero General Public License v3.0
25 stars 17 forks source link

Make bot mute be a global setting? #273

Open Torgen opened 6 years ago

Torgen commented 6 years ago

Transferring from Torgen/codex-blackboard#38. Chris Lopez complained during the test hunt that in one window, bot mute was set, and in another it wasn't. This would involve using localstorage (which we can do, as with the notifications), but it wasn't obvious this was desirable. I made a straw poll to get opinions. https://strawpoll.com/z49rzg9r

cscott commented 6 years ago

I think a refactoring of the settings-related code is in order, and moving all of the settings to global localstorage is reasonable. The cookie-based approach seems to be partially broken and kludgy to read. Refactoring so that all the setting-access/init code is consistent, with perhaps a dedicated settings page (or at least a dropdown) for them, would probably be adventageous enough to outweigh folks' individual preferences for per-window settings. You can always toggle the bot if you want to be amused/do not wish to be amused in your current task. Perhaps there are other tweaks we could make w/o making the setting per-window, such as a preference for bot-amusement only in ringhunters (but not in puzzle pages) instead of banned everywhere, etc.

Part of my personal amusement comes from the fact that the meme bot is so unpredictable, and can sometimes be triggered by particular puzzle names or in otherwise-unexpected ways. I know not everyone shares my particular sense or humor, though.