search

cjb / serverless-webrtc

A demo of using WebRTC with no signaling server.
Other
1.54k stars 239 forks source link

[firefox] Prevent error when error callback is missing #11

Closed wilsonpage closed 9 years ago

cjb commented 9 years ago

Hi @wilsonpage, thanks for the patch! Do you have any info about why this is necessary now, whether it continues to work okay in Chrome after your patch, etc?

wilsonpage commented 9 years ago

@cjb everything appears to work fine in Chrome and FF after the patch. Not sure why it throws without the error callback. FYI Firefox seems to also support a promise API now, which doesn't throw if the error callback is missing.

cjb commented 9 years ago

@wilsonpage Okay, found a little more detail:

https://bugzilla.mozilla.org/show_bug.cgi?id=1063971

This bug suggests that the only release that it was broken on is Firefox 32.0.0, and it was fixed in Firefox 32.0.1 and later. The error callback is technically mandatory, but pretty much all the existing WebRTC code out there doesn't use one so they didn't intend to enforce that.

With that in mind, I think I'd like to either leave it as it is, or be consistent by adding failure callbacks to the other API calls in the same situation too, namely:

createOffer, createAnswer, setLocalDescription, setRemoteDescription, addIceCandidate.

What do you think?

wilsonpage commented 9 years ago

I'm running Nightly (v37) and I got the error. I don't mind how it's fixed, I just want the demo to work in Firefox :)

On Wed, Dec 17, 2014 at 9:41 PM, Chris Ball notifications@github.com wrote:

@wilsonpage https://github.com/wilsonpage Okay, found a little more detail:

https://bugzilla.mozilla.org/show_bug.cgi?id=1063971

This bug suggests that the only release that it was broken on is Firefox 32.0.0, and it was fixed in Firefox 32.0.1 and later. The error callback is technically mandatory, but pretty much all the existing WebRTC code out there doesn't use one so they didn't intend to enforce that.

With that in mind, I think I'd like to either leave it as it is, or be consistent by adding failure callbacks to the other API calls in the same situation too, namely:

createOffer, createAnswer, setLocalDescription, setRemoteDescription, addIceCandidate.

What do you think?

— Reply to this email directly or view it on GitHub https://github.com/cjb/serverless-webrtc/pull/11#issuecomment-67399625.

cjb commented 9 years ago

Merged in, thanks!