search

cjb / serverless-webrtc

A demo of using WebRTC with no signaling server.
Other
1.54k stars 239 forks source link

Resolve bugs and deprecation warnings #37

Closed LeaVerou closed 3 years ago

LeaVerou commented 4 years ago

Thank you for this fantastic project! This was the only WebRTC resource I actually found approachable.

As many issues have pointed out, this project has gotten out of date and now doesn't work in either Chrome or Firefox and just displays deprecation notices and errors. This PR attempts to fix most of these. It now mostly works in both Chrome and Firefox, though displays a stack overflow in Chrome (this PR does not introduce the stack overflow, it just doesn't fix it). I also removed adapter.js since browsers are now much more interoperable than they used to be back when this was first written. I ported attachMediaStream and reattachMediaStream directly in serverless-webrtc.js

It needs more work to fix everything but at least it's not completely broken after this PR is merged.

cjb commented 3 years ago

Thanks for the excellent PR, @LeaVerou, and I'm sorry for taking two years to merge it! I've fixed the "call stack exceeded" error on the main branch now too.