search

cjb / serverless-webrtc

A demo of using WebRTC with no signaling server.
Other
1.54k stars 239 forks source link

Broken in Chrome on Windows - jquery and getUserMedia detection, and non https - PR in comments #40

Closed manthrax closed 3 years ago

manthrax commented 4 years ago

jquery gets callstack exceeded because the previous modals are not "hide" before the next modal is "show".

getUserMedia in adaptor.js detection doesn't identify chrome... additionally.. if not in HTTPS, getUserMedia doesn't exist.. This can be trivially shimmed around, allowing the datachannel (chat) to work.

There is a loong delay between offer generation and the ICE server result.. 30 seconds or so each way on my setup.. Is this normal?.. would be cool if this was wrapped into a small library.

Cool project!

Here is a PR with what I had to break to get this to work on Chrome/Windows: Had to force "hide" any open modals before "show" ing the next one, or jquery gets a stack overflow... I fixed it for the host, but might not have for the client, but it all eventually works...

https://github.com/cjb/serverless-webrtc/pull/39

cjb commented 3 years ago

@manthrax Thanks! This should be fixed up on the main branch now.