Fixed context_annotations error when max_results > 100

cjbarrie / academictwitteR

Repo for academictwitteR package to query the Twitter Academic Research Product Track v2 API endpoint.

Other

272 stars 59 forks source link

Fixed context_annotations error when max_results > 100 #181

Closed justinchuntingho closed 3 years ago

chainsawriot commented 3 years ago

Actually, all tests involving get_all_tweets failed. The root problem is that the default GET request is changed in most cases. I will update those tests later.

chainsawriot commented 3 years ago

I've a feeling that all bind_tweets and its test cases need to change as well (as context.annotations as a field can be no longer there).

chainsawriot commented 3 years ago

old tests are fixed. But the added "feature" (restriction of page_n) is not tested.

chainsawriot commented 3 years ago

@justinchuntingho I think it is now tested. (Of course, one can make more extensive tests; but this is Sunday)

Feel free to squash and merge (Please don't create a merge commit; many missteps were in-between).