search

cjbarrie / academictwitteR

Repo for academictwitteR package to query the Twitter Academic Research Product Track v2 API endpoint.
Other
272 stars 59 forks source link

[FR] New test format #270

Closed chainsawriot closed 2 years ago

chainsawriot commented 2 years ago

Describe the solution you'd like

Newly written tests using the mocking API have this directive:

https://github.com/cjbarrie/academictwitteR/blob/85f82a882dcb769baea2caab74122b92009ac81a/tests/testthat/test-compliance.R#L34

With this directive, there is no need to skip the test in .Rbuildignore. Also, the check and test procedures in the GHA can be united.

https://github.com/cjbarrie/academictwitteR/blob/85f82a882dcb769baea2caab74122b92009ac81a/.github/workflows/R-CMD-check.yaml#L91-L92

Currently, there are so many test files in .Rbuildignore. These should be rewritten with the new format.

https://github.com/cjbarrie/academictwitteR/blob/85f82a882dcb769baea2caab74122b92009ac81a/.Rbuildignore#L20-L40

Anything else?

No response

chainsawriot commented 2 years ago

Related to this, I also suggest running tests in parallel.

chainsawriot commented 2 years ago

Forget about parallel testing, it doesn't support snapshot testing.