cjbassi / gotop

A terminal based graphical activity monitor inspired by gtop and vtop
GNU Affero General Public License v3.0
7.37k stars 440 forks source link

Intent to package: Snaps are universal Linux packages #119

Open brlin-tw opened 5 years ago

brlin-tw commented 5 years ago

Dear maintainer(s),

Snaps are universal Linux packages that can be installed and run on many GNU+Linux distributions with ease. I've been following the Snapcrafters instructions and have built a working snap on the Snap Store, you may try it by running the following commands after installing snapd:

# Install the snap
sudo snap install --channel=edge gotop-brlin

# Connect to the required confinement interfaces
## Required by "Temperatures" widget
sudo snap connect gotop-brlin:hardware-observe

## Required by "Disk Usage" widget
sudo snap connect gotop-brlin:mount-observe

## Required by "Processes" widget
sudo snap connect gotop-brlin:system-observe

# Launch the application
gotop-brlin

I'm also looking forward to working with you to make the packaging work upstream (if you're interested). You may want to check out the current packaging recipe, the documentation, registering a developer account on the Snap Store, and get in touch with us to transfer the work under your control.

Thanks for your time and attention.

Todo:

brlin-tw commented 5 years ago

screenshot_20190303_032146

Currently, the snap runs pretty well with only a known issue that it detects the wrong mount points in the "Disk Usage" widget partially due to Snapd's voodoo stuffs, however, I believe it can be workarounded easily.

brlin-tw commented 5 years ago

As you already aware, currently the gotop namespace is occupied by dawndiy/gotop: A top like command line tool with Terminal UI, you may:

yarbelk commented 5 years ago

https://flatpak.org/ ?

brlin-tw commented 5 years ago

https://flatpak.org/ ?

That's also feasible once they support creating command aliases (gotop) from the package identifier (like.cjbassi.gotop)

cjbassi commented 5 years ago

Sorry for the delay, some updates:

  1. I just added myself as a collaborator to the gotop-brlin package on snapcraft.io
  2. I cherry picked your commit from #120, so that's effectively merged

If you could rename the gotop-brlin package to gotop-cjbassi that would be great. Then I'll add the installation instructions to the readme. And then I'll make an effort to see about acquiring the gotop namespace on snapcraft.io.

Other issues:

  1. fixing the mountpoint issue
  2. add snap building and publishing to the travis ci

Thanks again @Lin-Buo-Ren!

brlin-tw commented 5 years ago

If you could rename the gotop-brlin package to gotop-cjbassi that would be great.

Currently snap rename isn't supported by the Snap Store, you'll have to obsolete the old name then register and publish the snap with the new name. You may register the new snap name via the https://dashboard.snapcraft.io/register-snap page. I can handle the old snap's obsoletion after you've published the new one(essentially printing a friendly notice for the old snap users to remove the old snap and install the new one, also the old snap will be unlisted to prevent new users from accidentally installing it).

add snap building and publishing to the travis ci

It is recommended to use the Snapcraft Build Service to build the snap directly from the repository, Travis CI is also possible but supporting multiple architecture releases will be a pain.

cjbassi commented 5 years ago

Thanks for the recommendations. I got the SnapCraft Build Service to work very easily, and there's now a snap published at gotop-cjbassi, so feel free to deprecate the other one. I also updated the top comment with a list of remaining todos.

brlin-tw commented 4 years ago

@cjbassi Hello. As you've dropped the maintenance of this project would you mind deprecating the go-top-cjbassi snap and make it unlisted in the Snap Store using these instructions?

Thanks in advance!