cjbassi / gotop

A terminal based graphical activity monitor inspired by gtop and vtop
GNU Affero General Public License v3.0
7.36k stars 437 forks source link

Crash shortly after starting #99

Closed ghost closed 5 years ago

ghost commented 5 years ago

Summary

Freshly baked 2.0.0; gotop crashes shortly after running for a few minutes. Per time, 2 minutes, 40 seconds after starting.

Required information:

gotop.errors.log (from ~/.local/state/gotop).

ghost commented 5 years ago

Updates

  1. No options: no crash after 30m
  2. -b: no crash after 10m
cjbassi commented 5 years ago

So I think this is the same concurrent map write issue as #96, which turned out to be a different issue than I fixed before. This one is particular to the CPU widget, which potentially spawns 2 goroutines when updating, which each write to the same map. Should be fixed on master now. Thanks again, I should've checked the logs more carefully.

ghost commented 5 years ago

Think I noted this on another ticket, but I'll be able to check this after Feb 8. Thanks for being patient on my confirmation!

ghost commented 5 years ago

I'm going to close this as confirmed fixed; I updated gotop on the VMs and they've all been running for over a half hour, so any other stability issues probably have some other root cause.

Thanks again for the fix!