cjbassi / ytop

A TUI system monitor written in Rust
MIT License
2.16k stars 84 forks source link

UI issues compared to gotop #67

Open absolutelynothelix opened 4 years ago

absolutelynothelix commented 4 years ago

i just discovered that gotop is not maintained anymore and ytop is kind of official replacement for it. well, i migrated to ytop from gotop and it... it just made me sad. i thought i will get a better gotop and i believe that ytop is actually better under the hood, but unneeded ui changes that mostly making ytop looking worse than gotop are just driving me crazy.

cpu usage new graph is awful compared to the gotop, but there is already a separate issue for this and i already said this there.

disk usage we got disk renamed to partition, which is good and right. but at the same time we lost ellipsis at the end of the partition name if it was cropped, so previously i had disk nvme0... which is wrong and now i have partition nvme0 which is wrong as well (applicable if gotop window takes half of the screen on my laptop). the worst case i guess if you'll have a lot of partitions named and numerated like "mmcblk0p9, mmcblk0p10, mmcblk0p11" and user will see "mmcblk0p9, mmcblk0p1, mmcblk0p1".

gotop: image ytop: image

temperatures old sensor names obtained some dashes, capital letters and spaces and now are looking super weird compared to the gotop.

gotop: image ytop: image

memory usage we lost fixed position of the slash that devides used and total memory, so now sometimes numbers are jumping left and right. awful new graph as well.

gotop: image ytop: image

processes process list lost left and right padding and process count for example is always near border, doesn't look good. also numbers seems to be aligned to the left now, when gotop had them aligned to the right, which looked better.

gotop: image ytop: image

well, let this issue be a place for all people a little disappointed in ytop. i hope ytop will look at least like gotop and even better so it will be a really good replacement for gotop.

cjbassi commented 4 years ago

I acknowledge and agree there are some rendering issues compared to gotop, and i've been meaning to get to those, i've just been busy with other things. If you prefer to use gotop for now, that's fine, but feel free to open pull requests to fix these issues if you want. Also, i would appreciate if you could be a little kinder with the way you are raising these issues, there is no need to call things awful or title this issue in an inflammatory way.

In regards to the rendering, one thing to note is that the temperature names are {unit}-{sensor} with the sensor names being pulled directly from the os. But if we still think we should change the sensor name formatting then i am open to discussing that.

absolutelynothelix commented 4 years ago

If you prefer to use gotop for now, that's fine, but feel free to open pull requests to fix these issues if you want.

i prefer to feedback on new things to make them better and/or suit me instead of sticking to old things. i can't make a pr since i'm not really interested in ytop development (but interested in using) and i've never touched rust.

Also, i would appreciate if you could be a little kinder with the way you are raising these issues, there is no need to call things awful or title this issue in an inflammatory way.

i don't want to offend anyone. it's a bit hard for me to pick right words since english is not my primary language and i have not that big vocabulary. i also don't want to say that ytop completely disappointed me or made me extermely sad. feel free to prefix "a little" to these. btw, i wanted to chage the title from "disappointed" to "a little disappointed" but thought that i have changed it too much.

In regards to the rendering, one thing to note is that the temperature names are {unit}-{sensor} with the sensor names being pulled directly from the os.

why they're different in gotop and ytop? anyway, i don't really see a way to make sensor names look fancy (until you can somehow say that this sensor reflects cpu temperature, this sensor reflects gpu temperature, etc.), so i prefer to stick to their "raw" names (coretemp_packageid0 instead of coretemp-Package id 0)

cjbassi commented 4 years ago

so i prefer to stick to their "raw" names (coretemp_packageid0 instead of coretemp-Package id 0)

coretemp-Package id 0 is the raw name. But I don't mind changing it if that's what people want.

On another note, the process widget and the graph lines should be fixed now.