search

cjbhaines / Log4Net.Async

Asynchronous Log4Net appenders and forwarder
http://www.nuget.org/packages/Log4Net.Async/
MIT License
121 stars 37 forks source link

BufferSize Fix #14

Closed JohnDRoach closed 9 years ago

JohnDRoach commented 9 years ago

G'Day cjbhaines,

I have made a change to BufferSize so it is no longer 'nullable'. I have tested this with values of 1000 and 1000000. I haven't run all your unit tests as some appeared to not want to run for me. I also haven't tested with a blank value in the configuration. This was all done to get around the inability to set the BufferSize from the configuration (Issue #13), 1000 was just a little too small for my application.

Cheers, John

rcollette commented 9 years ago

Thank you for the fix. I"m sorry I have had little time to contribute these days. I'm primarily doing client side Angular development on a Mac and don't have Visual Studio handy as I used to.