search

cjbooms / fabrikt

Generates Kotlin Code from OpenApi3 Specifications
Apache License 2.0
158 stars 41 forks source link

support kotlinx.serialization #89

Open christophsturm opened 2 years ago

christophsturm commented 2 years ago

This library looks great, are you planning to add support for kotlinx serialization, or would you accept a pr that adds it?

cjbooms commented 2 years ago

I would be very receptive to PRs, but have no experience with kotlinx serialization.

ulrikandersen commented 10 months ago

@zettelmj Have you been able to make progress on adding Kotlinx Serialization to the library?

Serisium commented 4 months ago

@zettelmj and @ulrikandersen, I am interested in tackling this feature. How has your experience been so far, and do you have any advice for getting started?

Thank you for your work so far!

ulrikandersen commented 4 months ago

@Serisium I am happy to help with code reviews and feedback along the way! It would be a great addition to the library 🙌

@zettelmj has taken the first steps in #249, so I guess that would be the place to start.

zettelmj commented 4 months ago

Hi Sorry for the late answer. I did try to tackle the whole problem at once. In retrospective that is most probably a step too big. I should have gone for the model part first. I would suggest the same: Add the code that allows for the model part of the process in first. I am planning to look into adding end 2 end tests for the existing Jackson based serialisation over the weekend.

ulrikandersen commented 1 week ago

With the release of 18.0.0, Fabrikt is now capable of generating models with kotlinx.serialization annotations.

Take it for a spin, and please do not hesitate to share feedback and/or open PRs with suggestions for improvements.