cjcliffe / CubicSDR

Cross-Platform Software-Defined Radio Application
http://www.cubicsdr.com
GNU General Public License v2.0
2.02k stars 249 forks source link

Cleanup: C++11 updates, clean-up, warning fixes #885

Closed cjcliffe closed 3 years ago

Dantali0n commented 3 years ago

These look good, personally I like the explicit constructors and adding the intent to function arguments although I am not sure they are needed in clear get / set functions. However, you could of course make the argument that consistency is more important.

Personally I'd wish C++ had function argument intent keywords with well defined restrictions and the subsequent compiler warnings / errors.