modem volume controls - Githubissues

cjcliffe / CubicSDR

Cross-Platform Software-Defined Radio Application

http://www.cubicsdr.com

GNU General Public License v2.0

2.06k stars 253 forks source link

modem volume controls #892

Closed colbyAtCRI closed 2 years ago

colbyAtCRI commented 3 years ago

I've added a class ModemAnalogVC which has ModemAnalog as a base class. This adds user settable modem gains to any modem that uses this base class. I've applied this to AM, CW, DSB, USB, and LSB modems. Current default is to have a modem gain of 15 dB with Auto Gain off.

Screen Shot 2021-05-20 at 4 34 38 PM

colbyAtCRI commented 3 years ago

This is in response to #826

vsonnier commented 2 years ago

Hi @colbyAtCRI could you please rebase your work on the current Cubic master, it will be easier to merge.

vsonnier commented 2 years ago

Some generic remarks:

The default setting should be Auto gain = on, as before
The save/load mechanism is missing for session xml for the additionnal options (?)
As said above, do not apply any re-formatting if possible for this commit, in order to facilitate review.

vsonnier commented 2 years ago

To be clear @colbyAtCRI we really appreciate your efforts, here ! Unfortunatly there are lots of uninteresting little details to fix before the commit could be accepted, so that the code stays clean and consitent for the future. I have little time to work on Cubic these days, so I'm just giving cheap advice here, sorry for that.

colbyAtCRI commented 2 years ago

Okay, I think I did that correctly

colbyAtCRI commented 2 years ago

Okay, so I'm a little uncertain as to my next move. The save/load feature I didn't implement should be added by all means. I'm uncertain on how this is done.

I will try to compile the latest version of Cubic. If it compiles on my MacPro, I'm open to figuring the save/load stuff out.

Dantali0n commented 2 years ago

Hi @colbyAtCRI Thanks for the patch, I'll try to isolate and remove the linting changes on my part and be sure to tag you as author in the commits.

Don't worry about save/load if you don't have time to figure it out / get a development environment going right now. We could do that in a later patch as far as I am concerned.