cjcliffe / CubicSDR

Cross-Platform Software-Defined Radio Application
http://www.cubicsdr.com
GNU General Public License v2.0
2.02k stars 249 forks source link

Don't compile on make: modemcf_get_demodulator_evm issue #932

Closed CristianRossiSorint closed 2 years ago

CristianRossiSorint commented 2 years ago

I tried to compile CubicSDR with liquid-dsp master version (1.3.2) and after with v 1.3.0, but nothing changed, it returns this error on make:

bios@archinator:[~/Downloads/Software/CubicSDR/build]$> make -j6
[  1%] Linking CXX executable x64/CubicSDR
/usr/bin/ld: CMakeFiles/CubicSDR.dir/src/modules/modem/ModemDigital.cpp.o: in function `ModemDigital::updateDemodulatorLock(modemcf_s*, float)':
ModemDigital.cpp:(.text+0xde): undefined reference to `modemcf_get_demodulator_evm'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/CubicSDR.dir/build.make:1466: x64/CubicSDR] Error 1
make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/CubicSDR.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

It seems an error referred to src/modules/modem/ModemDigital.cpp at line 52:

void ModemDigital::updateDemodulatorLock(modemcf mod, float sensitivity) {
    setDemodulatorLock(modemcf_get_demodulator_evm(mod) <= sensitivity);
}
vsonnier commented 2 years ago

Duplicate of #930

CristianRossiSorint commented 2 years ago

Duplicate of #930

I already tried to get and install liquid-sdp from master.

vsonnier commented 2 years ago

A reopened #930. As I said there, I have no problem when both Cubic and liquid-dsp are from master, on Windows. It may be a Linux specific problem. Please continue the discussion in #930.