search

cjcodeproj / musicscan

Python code to examine music files and extract metadata
MIT License
0 stars 0 forks source link

Code should accommodate for empty environmental variable #7

Closed cjcodeproj closed 3 months ago

cjcodeproj commented 3 months ago

The code should be able to handle a run if the MUSICPATH variable is empty.

cjcodeproj commented 3 months ago

Commit:

https://github.com/cjcodeproj/musicscan/commit/55571d95cc32bac3bced04ca4ec3350485a57fd0

cjcodeproj commented 3 months ago

Closing notes:

There is a weird error where PyLint is assuming the musicscan variable is a constant, when it is not meant to be.

cjcodeproj commented 3 months ago

Re-opening issue:

The code could be a little bit cleaner, with less if branching; also the pylint rule exception bugged me.

cjcodeproj commented 3 months ago

New commit:

https://github.com/cjcodeproj/musicscan/commit/0534e1b877f6d2b3ff54dbd1a09036871fb263a2