cjdelisle / packetcrypt_rs

PacketCrypt in Rust
53 stars 43 forks source link

Fixed bugs in miner #33

Closed UCIS closed 2 years ago

UCIS commented 2 years ago

These 4 patches fix several bugs in the miner:

  1. only the first announcement in a jumbo frame received in the non-GSO path was handled
  2. the final sequence of announcements with equal properties (height, target) in a received buffer was discarded
  3. a buffer allocated for the proof structure was too small causing memory corruption, an argument declaration caused a null check to be dropped when compiling with clang, causing segmentation faults in the blockminer
  4. libsodium needs to be initialized for optimal performance (should do this for all operations, not just the announcement miner)
cjdelisle commented 2 years ago

Thank you very much !