search

cjdelisle / packetcrypt_rs

PacketCrypt in Rust
54 stars 45 forks source link

Ignore "invalid" domain in announcement uploader #44

Closed UCIS closed 2 years ago

UCIS commented 2 years ago

This patch allows pools to specify announcement handlers using the "invalid" domain to indicate that they do not wish to receive any announcement destined for a specific handler. This can be used as a method to manage the bandwidth on a pool that can not affect the miner difficulty, without the errors caused by other invalid or dead handler addresses.

The invalid TLD is reserved by the IETF in RFC 2606 as a domain name that may not be installed as a top-level domain in the DNS of the Internet. This makes it a good candidate for the intended purpose as it will both ensure that there are no unintended matches, and also that the use in miners without this patch will still result in the desired effect (announcements not being sent anywhere).

I don't really like to make pool-specific changes in the code, but this seems like a better idea than recommending to just suppress error messages entirely, and might be useful for others.

cjdelisle commented 2 years ago

Merged to develop branch, thank you !