JShint was ignoring my code encoding

cjdev2 / jshint-mojo

A simple, speedy maven plugin for running javascript code through jshint

GNU General Public License v2.0

40 stars 32 forks source link

JShint was ignoring my code encoding #47

Closed velo closed 9 years ago

velo commented 10 years ago

Hi,

I'm running JSHint on a project and it start failing on windows machines with the following error: "This character may get silently deleted by one or more browsers."

It turns out, the plugin was ignoring maven enconding.

Add a parameter to allow setting my enconding (or using the one already set for maven).

stupenrose commented 10 years ago

Sorry, for the slow response - very busy at work. I think we're at a point with the mojo where I'm reticent to add new functionality unless we have corresponding test coverage; I'd like to preserve our ability to crank out new releases with minimal work (i.e. without having to go through a manual testing episode/phase). So, long story short: can you please submit a test?

velo commented 10 years ago

I can do it, can you just point me to a sample?