jbrea
commented
2 years ago Ah, yes, thanks. (for unknown reasons I didn't see your comment on github).
On Thu, Nov 11, 2021 at 01:34:52AM -0800, Christopher Rowley wrote:
@cjdoris commented on this pull request.
@@ -972,11 +972,19 @@ end return (pos, done) end
+_zero(::Any, ::Any, ::Any, ::Any) = 0 +function _zero(::AbstractVector{<:Union{<:AbstractString, Missing}}, r, i, nrows)
- @warn("Value of string column '$(r.colnames[i])' (index $(i-1)) is 0 in sparse row $nrows (see warning in section sparse ARFFF files https://waikato.github.io/weka-wiki/formats_and_processing/arff_developer/")
- "" +end +function _zero(::CategoricalVector, r, i, nrows)
- r.pools[r.coltypeidxs[i]][1]
I believe this should be
r.pools[r.colkindidxs[i]][1]-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/cjdoris/ARFFFiles.jl/pull/14#pullrequestreview-803588936
cjdoris
@cjdoris Did you have a chance at looking at this?