search

cjdrake / pyeda

Python EDA
BSD 2-Clause "Simplified" License
311 stars 56 forks source link

Use alloca instead of variable-length arrays to ease builds on Windows #153

Closed alexwebr closed 2 years ago

alexwebr commented 5 years ago

This fixes #152. When installing on Windows through pip, this allows the extension to be compiled without errors.

FaustinCarter commented 3 years ago

@cjdrake This is an old PR, but I would like to see this merged in if possible. I'm running into the exact same issue on Windows.

cjdrake commented 3 years ago

I haven't been able to spend any time on this project lately (ie, for a few years now). Even if I merged the PR, I don't have a machine to test the build with.

I'm not sure how many people use this library, but it's more than zero. Is there a good solution for doing a handoff or adding a maintainer?

FaustinCarter commented 3 years ago

Adding a maintainer is as easy as giving them permissions to push to the repository (and presumably to manage pipelines/actions). That being said, I don't have the resources (nor probably the specific knowledge) required to be that person.

One thing I will say is that testing across various architectures is relatively straightforward with GitHub Actions. One can build and test on linux, osx, and windows all in an automated fashion.

ruancomelli commented 2 years ago

@cjdrake @FaustinCarter I forked this repo and added a GitHub Action to build it: https://github.com/sourcery-ai/pyeda. I also had trouble trying to build the code on the main branch, and this PR fixed it for me (as you can see in the workflow run details). Even if this package is not directly maintained anymore, it would be great if you could accept and merge this PR :smile:

cjdrake commented 2 years ago

SGTM. Thanks :)