cjdrake / pyeda

Python EDA
BSD 2-Clause "Simplified" License
311 stars 56 forks source link

Expression to_dot syntax error #182

Closed fzanollo closed 10 months ago

fzanollo commented 11 months ago

It seems a typo was added in some cleaning of the expr.py file at commit Lint cleanup: expr.py, changing ' for ".

Solution: change

    def to_dot(self, name="EXPR"): # pragma: no cover
        """Convert to DOT language representation."""
        parts = ["graph", name, "{', 'rankdir=BT;"]

to

    def to_dot(self, name="EXPR"): # pragma: no cover
        """Convert to DOT language representation."""
        parts = ["graph", name, "{", "rankdir=BT;"]

I'm ready to create a pull request if it helps you at all, thank you for this useful library!

cjdrake commented 11 months ago

Nice find :). Yes, please create a pull request.